MyPy Compliance #1300
Merged
MyPy Compliance #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: infrastructure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 91.67% 91.61% -0.06%
==========================================
Files 60 60
Lines 3016 3031 +15
==========================================
+ Hits 2765 2777 +12
- Misses 251 254 +3 ☔ View full report in Codecov by Sentry. |
trexfeathers
commented
Jan 29, 2025
bjlittle
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Awesome effort @trexfeathers 💥🚀
Just a few minor comments to service then we can bank this typing loveliness 💯👌
bjlittle
approved these changes
Jan 31, 2025
|
@trexfeathers 🥳 🎉 🏆 |
|
Thanks @bjlittle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
See project item